-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$ref overwrites nullable
property
#159
Comments
Thanks for the bug report!
What changed since yesterday? Did some dependency get upgraded? This looks like it might be a bug in https://github.com/p1c2u/openapi-core (that pyramid_openapi3 depends on). |
That's the mystery for us, since no packages that we explicitly use have been updated since the last couple of days. Might be one of the implicit dependencies of those packages.` On our side https://github.com/p1c2u/openapi-core is frozen to version 0.13.8, because one of the dependencies requires version of openapi-core to be < 0.14. So at least openapi-core remained the same on our side. |
It seems the offending implicit dependency package that causes this issue is |
I have noticed something which might be related to this issue. We have the following warning from
And in |
Hey @bushkov, did you manage to resolve this, or is the issue still there? |
No, the issue is still there. |
The underlying problem seems to have been addressed in |
@zupo Any update on this issue? I still get |
As per python-openapi/openapi-schema-validator#22, have you tried using |
Yes, I still get the error even with |
That is indeed strange. I'll try to take a look in the not too distant future. Any help debugging this is greatly appreciated. If you have any additional info, please share. Or even a failing tests that showcases exactly how the thing fails. |
You can use the example with the modified TODO app which I mentioned in my first comment of this issue. If you modify the TODO app following the instructions in the comment and then execute the tests from the TODO app directory, the tests will fail with:
|
@zupo any update for this issue? We;re also running into the same problem as this example. |
The entire |
If a property is defined via a
$ref
and it'snullable
set toTrue
, then this nullable will be ignored.If you take an example from the TODO app, make a
title
nullable:and modify
ITEMS
inapp.py
to contain an item withnull
property:Then everything works fine.
However, if we define
title
via a$ref
:Then we get the following error:
Note that we started observing this error only since yesterday, before it was working as expected.
The text was updated successfully, but these errors were encountered: