Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up comparisons with disperate variable sets #11

Open
haz opened this issue Jul 30, 2020 · 3 comments
Open

Fix up comparisons with disperate variable sets #11

haz opened this issue Jul 30, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@haz
Copy link
Collaborator

haz commented Jul 30, 2020

When a theory doesn't mention all of the variables, then counting, comparing, etc all become incorrect. Ultimately, a fix will need to come in the form of an NNF potentially storing a superset of the variables currently mentioned in descendants via the walk functionality.

@haz haz added bug Something isn't working help wanted Extra attention is needed labels Jul 30, 2020
@haz haz mentioned this issue Jul 30, 2020
@haz
Copy link
Collaborator Author

haz commented Jul 30, 2020

This assumption should go away once this issue is resolved.

@blyxxyz
Copy link
Collaborator

blyxxyz commented Jul 30, 2020

I gave this some thought during initial development but didn't come up with anything that really felt right.

One fix could be to add an optional keyword argument names for passing an explicit set of variables.

Comparing using the current behavior of .equivalent() is resistant to this problem, at least.

@haz
Copy link
Collaborator Author

haz commented Jul 30, 2020

Ya, I considered the names argument too. Problem there is that it proliferates -- many places might need it (or have sub-procedures that need it). The make_smooth operation is certainly one that would require it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants