Skip to content

Commit

Permalink
feat(WebSocketSubject): no longer extends Subject.
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `WebSocketSubject` is no longer `instanceof Subject`. Check for `instanceof WebSocketSubject` instead.
  • Loading branch information
benlesh committed Nov 22, 2023
1 parent 245c412 commit 54f2f6e
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const WEBSOCKETSUBJECT_INVALID_ERROR_OBJECT =

export type WebSocketMessage = string | ArrayBuffer | Blob | ArrayBufferView;

export class WebSocketSubject<T> extends Subject<T> {
export class WebSocketSubject<T> extends Observable<T> {
private _config!: WebSocketSubjectConfig<T>;

private _output: Subject<T>;
Expand Down Expand Up @@ -365,6 +365,5 @@ export class WebSocketSubject<T> extends Subject<T> {
_socket.close();
}
this._resetState();
super.unsubscribe();
}
}

0 comments on commit 54f2f6e

Please sign in to comment.