Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexboxification #68

Open
ashfurrow opened this issue Mar 5, 2018 · 2 comments
Open

Flexboxification #68

ashfurrow opened this issue Mar 5, 2018 · 2 comments

Comments

@ashfurrow
Copy link
Member

Right now we use a kind of flowing grid to lay out all the cards on the site. That causes a problem when one card in a row is taller than the other cards in that row:

screen shot 2018-03-05 at 11 07 04 am

We should migrate our layout to use Flexbox, which presents an interface similar to UICollectionView for laying out items in a flow, line-breaking layout style. This will eliminate the gaps in between cards and their next rows.

@ashfurrow
Copy link
Member Author

An alternate approach would be to use CSS grids to force the cells to all have the same height. Example here: https://twitter.com/kizmarh/status/994260528594907136

@freak4pc
Copy link
Member

The only issues with the CSS grids approach is it doesn't allow "aligning to each other" - there has to be an "original" piece that everyone conform to. In that sense that piece will have to be found based on the length of the string or something more involved, which might not be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants