Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move depth-first threshold into a CMake/Run-time variable #11

Open
SSoelvsten opened this issue May 19, 2023 · 1 comment
Open

Move depth-first threshold into a CMake/Run-time variable #11

SSoelvsten opened this issue May 19, 2023 · 1 comment
Labels
cmake Build System enhancement New feature or request

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented May 19, 2023

Currently, there is a hardcoded value of 219 threshold that switches whether an algorithm should be run with depth-first or with breadth-first operations. Yet, this variable was set based on hardware from the end of the 90s.

Hence, it would be useful if this variable could be changed more easily. This can be done in one of two ways:

  1. Turn it into a CMake variable that is then injected with the preprocessor.
  2. Turn the threshold into a global variable that you can change at run-time.
  3. Turn the threshold into a global variable that is set during initialisation based on the amount of available memory (see i-level cuts for Adiar here)
@SSoelvsten SSoelvsten added enhancement New feature or request cmake Build System labels May 19, 2023
@SSoelvsten
Copy link
Owner Author

Alternatively, one can base it off of the available memory. If all inputs and the worst-case output fit into memory, then do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build System enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant