Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stitched images have bottom and left edges cropped peeksection is ok #192

Open
raacampbell opened this issue Jun 23, 2021 · 1 comment
Open

Comments

@raacampbell
Copy link
Contributor

raacampbell commented Jun 23, 2021

This happened since changing the dominant Y tiling direction.

Ok, it's getting cropped at around line 250 of stitcher:

if allowPartialTiles && ~isempty(maxPixelPos)
    stitchedPlane = stitchedPlane(1:maxPixelPos(1), 1:maxPixelPos(2),:);
end

This happens because maxPixelPos is wrong. In turn this seems to arise from:

imagedExtent = determineStitchedImageExtent;
maxXY = max(stagePos2PixelPos([imagedExtent.minXY;imagedExtent.maxXY],voxelSize));

Problem commit from BakingTray :
version: branch=dev commit=4aaa71914125af491d1396b9749c88ac91acad0e

@raacampbell
Copy link
Contributor Author

I could have sworn this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant