Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why qx = 1.0 in Eagle2? #93

Closed
haiduo opened this issue Jul 12, 2024 · 2 comments
Closed

Why qx = 1.0 in Eagle2? #93

haiduo opened this issue Jul 12, 2024 · 2 comments

Comments

@haiduo
Copy link

haiduo commented Jul 12, 2024

EAGLE/eagle/model/utils.py

Line 387 in 3585477

qx = 1.0

@haiduo haiduo mentioned this issue Jul 24, 2024
Closed
@Liyuhui-12
Copy link
Collaborator

Because top-k sampling is used in the draft phase, when a previous draft token is rejected, the sampling probability of the current draft token is 1.

@haiduo
Copy link
Author

haiduo commented Aug 8, 2024

Hi @Liyuhui-12 , Haha, I finally got it, thank you for your reply!

@haiduo haiduo closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haiduo @Liyuhui-12