-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with '-r' for valid compilable source #1319
Comments
After rewriting it to only use two arguments with
fib.jackt
fibonacci.lua
Native:
Optmized:
|
|
Unless the bug report is about the comptime interpreter
In which case, yeah, #soon maybe for the second one, and there's definitely a lot we can do to make it faster; but due to (3) I consider perf work on the interpreter to be premature...unless we come up with an entirely different architecture. |
Thank you for all feedback ! |
The https://github.com/SerenityOS/serenity/blob/master/Userland/Libraries/LibJS/Interpreter.cpp seems to have a reasonable performance. Although testing the sample bellow at https://libjs.dev/repl/ give an error:
Console error (dev tools):
|
That just looks like a typical stack overflow. We can't possibly know the stack bounds on wasm without some serious hax. Any LibJS bugs or errors should be reported on the serenity issue tracker though. |
After building
jakt
withclang-15
and try the sample shown bellow I'm getting an error when trying to only run it:fib.jakt
Compile/run output:
The text was updated successfully, but these errors were encountered: