Fail early on failed user creation

[empwilli]

I think it would be useful if the startup script would stop/fail early, if there was an error in the user creation. Currently, these errors are reported to the container logs but the server starts up anyway.

In my setup I had a faulty group ID and I struggled for quite some time why I couldn't connect to the server. IMHO this qualifies as an unrecoverable configuration error and the startup script should fail.

I'm looking for thoughts/opinions and if you want to I can take care of this issue.

[MarvAmBass]

thanks for the request, you mean if you have a uid / gid collision? or do you have other problems in mind?

[empwilli]

In this case I had a GID collision with an additional group.

[MarvAmBass]

I'm still thinking about the implementation - I don't want to break compatibility - but if some people let other people choose groups and pull down a whole server they get in trouble.

maybe I add a FAIL_FAST env which can be set to enable this behavior

[h-arnold]

Hey all!

I had the same issue and while I haven't adjusted the script to fail early, I think I've fixed the bug you're referring to here: #140

I've added logic to the entrypoint.sh script to check for existing users and delete them if they exist and moved the group creation to follow the user creation to avoid GID collisions.