-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail early on failed user creation #139
Comments
thanks for the request, you mean if you have a uid / gid collision? or do you have other problems in mind? |
In this case I had a GID collision with an additional group. |
I'm still thinking about the implementation - I don't want to break compatibility - but if some people let other people choose groups and pull down a whole server they get in trouble. maybe I add a |
Hey all! I had the same issue and while I haven't adjusted the script to fail early, I think I've fixed the bug you're referring to here: #140 I've added logic to the entrypoint.sh script to check for existing users and delete them if they exist and moved the group creation to follow the user creation to avoid GID collisions. |
I think it would be useful if the startup script would stop/fail early, if there was an error in the user creation. Currently, these errors are reported to the container logs but the server starts up anyway.
In my setup I had a faulty group ID and I struggled for quite some time why I couldn't connect to the server. IMHO this qualifies as an unrecoverable configuration error and the startup script should fail.
I'm looking for thoughts/opinions and if you want to I can take care of this issue.
The text was updated successfully, but these errors were encountered: