Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE: Rolling update doesn't work well #241

Open
myyrakle opened this issue Apr 9, 2023 · 1 comment
Open

GKE: Rolling update doesn't work well #241

myyrakle opened this issue Apr 9, 2023 · 1 comment
Assignees

Comments

@myyrakle
Copy link
Contributor

myyrakle commented Apr 9, 2023

Rolling update doesn't work well in gke.

In my opinion, if I redeploy with the same toml configuration, weaver should basically do a rolling update with no downtime.
If not, please correct me.

So, currently I have implemented the health check API in the form of "GET /".

And actually, the old version of the deployment is going down based on the health check.

The problem is that switching between versions of the server is not done non-disruptively.

image

A load balancing error occurs for a while as above.
What could be the problem?

# weaver.toml
[serviceweaver]
name = "weaver-start"
binary = "./weaver-start"

[gke]
regions = ["asia-northeast3"]
public_listener = [
  {name = "weaver-start", hostname = "myyrakle.com"},
]
@spetrovic77
Copy link
Contributor

Hi @myyrakle,

Thanks for pointing this out, this is a known issue. As far as we can tell, we're updating the external load-balancer gradually and with the right set of traffic shares, but it does error out for a brief period of time during the traffic change.

We're working on resolving this issue. And you're right, the intention is that you just set the rollout period in your configuration file and the framework ensures that the new version is deployed gradually and safely, without any service interruption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants