Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Mutliline Backtick Support #145

Open
juakotorres opened this issue Jan 17, 2022 · 3 comments
Open

Mutliline Backtick Support #145

juakotorres opened this issue Jan 17, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@juakotorres
Copy link
Contributor

Request / Idea

Before the pug warnings or errors, I got multiple warnings like this:

Please report token: {"type":"attribute","loc":{"start":{"line":26,"column":5},"end":{"line":31,"column":7}},"name":":rules","val":"`[\n      v => $v.form.email.required,\n      v => $v.form.email.email,\n      v => $v.form.email.maxLength,\n      v => $v.form.email.validOnServer,\n    ]`","mustEscape":true}

It does not affect the library functionalities, but it could be nice to have the support. For example when you use validation libraries.

Input

input("email", "email", "email", "EMAIL")(
  v-model.trim="form.name"
  :rules=`[
    v => $v.form.email.required,
    v => $v.form.email.email,
    v => $v.form.email.maxLength,
    v => $v.form.email.validOnServer,
  ]`
)

Expected Output

No report token log.

Additional Context

@Shinigami92 Shinigami92 added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2022
@Grawl
Copy link

Grawl commented Jan 24, 2022

have the same issue with Vue

	TwoPaneForm(
		:input='store.text'
		:input-is-invalid-label=`$t('rewriter.invalid-source', {
			min: validationRules.minimumWords,
			max: $tc('count.words', validationRules.maximumWords),
		})`
		:input-validator='textIsValid'
		:input-placeholder=`$t('rewriter.source-placeholder')`
		:result-input-classes=`{ '_sentences': enableSentencesModel }`
		:result-is-empty='!hasRewritten'
		v-bind='{ textIsChanged, isEmpty }'
		:loading='store.loading'
		@input='setText($event)'
	)
Please report token: {"type":"attribute","loc":{"start":{"line":8,"column":3},"end":{"line":11,"column":6}},"name":":input-is-invalid-label","val":"`$t('rewriter.inva

@Shinigami92
Copy link
Owner

The line is here

console.debug('Please report token:', JSON.stringify(token));

Who wants to help and setup a PR for that?

@Grawl
Copy link

Grawl commented Jan 24, 2022

i have no background in tool development, sorry :( just a frontend designer, more tied with Figma than Typescript

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants