Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of plotting and analysis functions #71

Open
leloup314 opened this issue May 24, 2017 · 1 comment
Open

Separation of plotting and analysis functions #71

leloup314 opened this issue May 24, 2017 · 1 comment

Comments

@leloup314
Copy link
Member

Like in the generate_pixel_mask and cluster_hits function of hit_analysis, plotting is done separately from the analysis, with an independent plotting function from plot_utils. I guess this should be the general approach of handling plotting since it is much more conveinient to have separate functions in case one needs to plot something externally. Maybe we can implement this in the future for all functions of the analysis.

@DavidLP
Copy link
Collaborator

DavidLP commented May 25, 2017

Yes, this is the way to do it. Right now there might be still some analysis parts in the plotting functions, since the separation of analysis and plotting was introduced when the code was already rather feature complete. Fell free to change that.

@DavidLP DavidLP added this to To Do in First Major release May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants