[bug] SpeedMax attribute missing for Fan device type

[lboue]

Hardware

Silicon Labs xG24 Explorer Kit

Core version

2.0.0

Arduino IDE version

2.3.2

Operating system

Windows 11

Radio stack variant

Matter

OpenThread Border Router device (if using Matter)

Apple TV 4K

Issue description

The Matter specifications indicate that this attribute is mandatory but SpeedMax attribute missing for Fan device type.

Matter-1.3-Application-Cluster-Specification.pdf page 306

4.4.6.5. SpeedMax Attribute
This attribute SHALL indicate that the fan has one speed (value of 1) or the maximum speed, if the
fan is capable of multiple speeds.

I don't find SpeedMax Attribute in MatterFan.cpp:

arduino/libraries/Matter/src/MatterFan.cpp

Lines 36 to 44 in 65a739a

	// Fan control cluster attributes
	DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(fanControlAttrs)
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::FanMode::Id, INT8U, 1, ATTRIBUTE_MASK_WRITABLE), /* FanMode */
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::FanModeSequence::Id, INT8U, 1, 0), /* FanModeSequence */
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::PercentSetting::Id, INT8U, 1, ATTRIBUTE_MASK_WRITABLE), /* PercentSetting */
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::PercentCurrent::Id, INT8U, 1, 0), /* PercentCurrent */
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::FeatureMap::Id, BITMAP32, 4, 0), /* FeatureMap */
	DECLARE_DYNAMIC_ATTRIBUTE(FanControl::Attributes::ClusterRevision::Id, INT16U, 2, 0), /* ClusterRevision */
	DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();

Serial output

No response

RTT output (if using Matter)

No response

Minimal reproducer code

matter_fan.ino

[lboue]

Check my PR #68 for this.

[silabs-bozont]

Hello @lboue,
Thank you for the finding and the PR. Unfortunately we don't have the community contributions set up yet - is it okay with you if I fix it in the upstream without your PR?

[lboue]

Yes, no problem with that

[silabs-bozont]

Hello @lboue,
It has been fixed in 2.1.0 - thank you for the report!

[lboue]

Thanks @silabs-bozont for this fix.