Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to dart-sass #397

Closed
GrimLink opened this issue Oct 27, 2020 · 2 comments
Closed

Upgrade to dart-sass #397

GrimLink opened this issue Oct 27, 2020 · 2 comments

Comments

@GrimLink
Copy link
Contributor

Node-sass has been officially marked as deprecated -> sass/node-sass#2952 (comment)
This does not mean it will not get any maintenance releases.
But it will not get any new features releases.
@Igloczek
Copy link
Contributor

Unfortunately, Dart Sass does not support exactly the same set of syntax features as Node Sass and it will require some changes on the themes level to adjust the code to the new compiler (for example @extend .button:disabled doesn't work anymore).

I'll add a feature flag to use Dart Sass, but not set it as default, at least for now.

@Igloczek
Copy link
Contributor

Dart Sass support released in v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GrimLink @Igloczek