Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh and git submodules #20

Open
danielk333 opened this issue Mar 11, 2022 · 0 comments
Open

build.sh and git submodules #20

danielk333 opened this issue Mar 11, 2022 · 0 comments

Comments

@danielk333
Copy link

danielk333 commented Mar 11, 2022

Hey,
Nice to see neptune in the public now! Wanted to give it a go and encountered this:

When cloning the library by default git does not pull submodules but leaves an empty folder, this causes the build.sh to detect the folder, cd into it, do a git pull (now on the neptune library git remote since it does not detect this as a submodule) and the script fails.

It should probably be included in the readme that one needs to clone using git clone --recurse-submodules [email protected]:Space-Systems/neptune.git (using this, build.sh works flawlessly!) to get submodules or the bash-folder-exists test might be be exchanged with a git-remote check to see that its points to OPI.git? Or maybe a submodule pull git submodule update --init --recursive in the build.sh could be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant