Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squirrel dependency packages update #897

Open
GraySerg opened this issue Dec 9, 2016 · 11 comments
Open

Squirrel dependency packages update #897

GraySerg opened this issue Dec 9, 2016 · 11 comments
Labels
infrastructure Pull requests related dependencies, tooling or testing that the project needs

Comments

@GraySerg
Copy link

GraySerg commented Dec 9, 2016

Hi! Is it safe to update dependency packages of suirrel package to latest version?
For now VS suggest me to update
DeltaCompressionDotNet from 1.0.0 to 1.1.0
Mono.Cecil from 0.9.6.1 to 0.9.6.4
Splat from 1.6.2 to 2.0.0

@Thieum
Copy link
Contributor

Thieum commented Apr 30, 2019

DeltaCompressionDotNet has been updated to 1.1.0 in #803

@shiftkey shiftkey added the infrastructure Pull requests related dependencies, tooling or testing that the project needs label Apr 30, 2019
@Thieum
Copy link
Contributor

Thieum commented Apr 30, 2019

Request to update DeltaCompression to 2.0.0 - #1181
Mono.Cecil tested ok with 0.9.6.4, not with 0.10.0 - #1337
multiple issues with old version of SharpCompress - #1253
Splat bug - #1336

@stephenegriffin
Copy link

Porting over security note from #1253 so it's not lost:

There's an advisory on SharpCompress < 0.21 (adamhathcock/sharpcompress@80ceb1c)

@peppy
Copy link

peppy commented May 7, 2019

Don't forget #1362 (#1181 was closed in favour of this issue but this issue doesn't mention SharpCompress outside of follow-up comments).

@shiftkey
Copy link
Contributor

shiftkey commented May 7, 2019

@peppy thanks for the extra context. I'll also link to this comment to remind me about this:

The last time we tried [SharpCompress] it broke NuGet's garbage Zip parsing and broke a bunch of people

#1362 (comment)

@jeremy-bridges
Copy link

In order to support version 7.0.1 of Splat, Squirrel would need to require version 4.6.1 of the .NET Framework. Microsoft's guidance on this is below. Any feedback on making this move?

https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/versions-and-dependencies

@jmagly
Copy link

jmagly commented May 24, 2019

4.6.1 is 5 years old now, personally I would say go for it but I am just a user with only about 20 customers.

@thecodetinker
Copy link

Porting over security note from #1253 so it's not lost:

There's an advisory on SharpCompress < 0.21 (adamhathcock/sharpcompress@80ceb1c)

Hello - is there any progress on the SharpCompress update please? I am working to promote Squirrel for deploying applications within my company, but it's hard to make a case for it when it contains a known vulnerability.

From reading the background I appreciate this isn't a two-minute fix, but it would be great to have an idea of the current status, if possible? Thanks!

@Thieum
Copy link
Contributor

Thieum commented Jul 5, 2019

@thecodetinker merging #1362 would bring us to 0.22

/cc @shiftkey @robmen

@Thieum
Copy link
Contributor

Thieum commented Jul 11, 2019

@peppy thanks for the extra context. I'll also link to this comment to remind me about this:

The last time we tried [SharpCompress] it broke NuGet's garbage Zip parsing and broke a bunch of people

#1362 (comment)

Would it make sense to have a beta channel if this kind of issue are hard to track through unit tests?

@thecodetinker
Copy link

thecodetinker commented Jul 16, 2019

@peppy thanks for the extra context. I'll also link to this comment to remind me about this:

The last time we tried [SharpCompress] it broke NuGet's garbage Zip parsing and broke a bunch of people

#1362 (comment)

Would it make sense to have a beta channel if this kind of issue are hard to track through unit tests?

Thank you - I would be happy to use a beta channel for now. We don't have enough users (yet) that breaking would be a massive problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Pull requests related dependencies, tooling or testing that the project needs
Projects
None yet
Development

No branches or pull requests

8 participants