Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change argument name file for template in gen_[tec,sta,ini]_xml functions #45

Open
sbuis opened this issue Dec 13, 2023 · 0 comments
Open

Comments

@sbuis
Copy link
Member

sbuis commented Dec 13, 2023

In functions gen_usms_xml and gen_sols_xml, the argument file refers to the name of the file to crate, and there is an argument called template to provide the name of a template file.

In functions gen_tec_xml, gen_sta_xml, and gen_ini_xml, the name of the file to generate is set, not chosen by the user, but there is an argument called file to provide the name of a template file. Would be better if this argument is called template, to be homogeneous with th other functions (=> move file to deprecated argument).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant