Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters don't work correctly #14

Open
pedrofracassi opened this issue Aug 21, 2020 · 7 comments
Open

Special characters don't work correctly #14

pedrofracassi opened this issue Aug 21, 2020 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@pedrofracassi
Copy link
Member

After Japanese support was added in #9, I've noticed that the renderer doesn't handle special characters correctly.

Example: https://invidget.switchblade.xyz/discord-developers?language=ja

image

@pedrofracassi pedrofracassi added bug Something isn't working help wanted Extra attention is needed labels Aug 21, 2020
@pedrofracassi
Copy link
Member Author

Discord seems to use Hiragino Sans for japanese. We could try to use that as a fallaback for characters that Whitney doens't support.

@jaxxibae
Copy link
Member

But does it affect all dialects (Hiragana, Katakana and Kanji)? @Flicksie

@pedrofracassi
Copy link
Member Author

Discord seems to use a mix of hiragana and kanji (which should have been displayed in the screenshot above), so I guess it should affect Katakana too.

@jaxxibae
Copy link
Member

Ah, ight. PS: that workaround should also work for server names

@pedrofracassi
Copy link
Member Author

Yeah, I'll probably end up implementing some sort of global font fallback for all the text we render

@mome0320
Copy link
Contributor

mome0320 commented Jul 6, 2021

in #41 affect this issue.

image
in Discord css. it classified by region.

but How about use Noto Sans for these?
i know it haven't in Discord Client but I think It covered.

@jaxxibae
Copy link
Member

jaxxibae commented Jul 6, 2021

Noto Sans doesn't (at least) cover the Korean language, I think.
image
It could cover other ones, though, but I didn't test it. Most probably we would have to implement Apple SD Gothic Neo, Hiragino Sans, YaHei New and JhengHei.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants