Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invisible portions of icons better #23

Open
Phoenix616 opened this issue Sep 26, 2020 · 4 comments
Open

Handle invisible portions of icons better #23

Phoenix616 opened this issue Sep 26, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Phoenix616
Copy link
Contributor

Currently invisible portions of server icons get some strange outline around them when the normal invite widget just displays the normal background.

Invidget:
Invidget

Discord widget:
Discord

@perronosaurio perronosaurio added bug Something isn't working good first issue Good for newcomers labels Sep 26, 2020
@Doges
Copy link
Member

Doges commented Sep 27, 2020

Can reproduce, i'm gonna take a look.

@pedrofracassi
Copy link
Member

It being a squircle instead of a full circle is intentional, as that's how Discord displays invites afaik. Is the issue about the black background on the transparent parts?

@Phoenix616
Copy link
Contributor Author

It being a squircle instead of a full circle is intentional, as that's how Discord displays invites afaik. Is the issue about the black background on the transparent parts?

It's about the gray background and the border, should be pretty obvious from comparing the two images what I mean? 🤔

@pedrofracassi
Copy link
Member

Can you send me the server icon from that widget you're rendering?

I see that a transparent portion of the icon is black, that should be easy to fix, but I'm not sure about these edges you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants