Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of minor points #1

Open
fosero opened this issue Feb 4, 2022 · 1 comment
Open

A couple of minor points #1

fosero opened this issue Feb 4, 2022 · 1 comment

Comments

@fosero
Copy link

fosero commented Feb 4, 2022

Apologies for not providing a patch, but a few points.

  1. For rects I have to do it differently to make it work. For some reason your method just does not work for me, although it is seemingly the same thing.
Graphene.Rect().init(x1, y1, x2, y2)
  1. In the RoundedRect section you mention that a radius of 360 makes a circle, as this is per one corner a radius of 90 makes for a circle.
  2. See https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/196 for the Gdk.RGBA override being restored for GDK4. This allows for Gdk.RGBA(r, g, b, a) to work again. Also, for some more of these newer types overrides need to be added to make it cleaner to access them.
@Taiko2k
Copy link
Owner

Taiko2k commented Feb 4, 2022

Okay, I've applies changes for points 1 and 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants