Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Support docker-compose 2.x #124

Open
candidtim opened this issue Jun 7, 2022 · 3 comments
Open

Support docker-compose 2.x #124

candidtim opened this issue Jun 7, 2022 · 3 comments

Comments

@candidtim
Copy link

docker-compose 2.x changed the naming convention for containers: it uses dash - to separate the project and container names, instead of underscore _ that was used in 1.x. As a consequence, getDockerContainerId cannot find the containers because it assume the older naming convention.

This is a proposal to support both naming conventions, probably using a flag to switch between the two.

Relevant code from "docker compose":
https://github.com/docker/compose/blob/0062703bea796eca5b5f78a4779fa166cc18619c/pkg/compose/compose.go#L36

@serhiip
Copy link

serhiip commented Aug 11, 2022

My attempt to fix this issue is in PR #125

@dakaneye
Copy link

Second this fix, it's blocking my ability to use this plugin! PR has been open since August...

@bcarter97
Copy link

As a workaround you can either export COMPOSE_COMPATIBILITY=true in your bash profile or disable V2 in the Docker settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants