-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metamask approve doesnt work in GH actions #269
Comments
All good, I started using the playwright container rather than installing it in the GH action worked perfectly! |
Reopening as it fails sometimes and its to do with this: Error: page.waitForSelector: Timeout 1000ms exceeded.
Call log:
- waiting for locator('.mm-box--color-error-default') to be visible I believe its the |
oh interesting. Something to look into for sure. |
@conwayconstar there has been a couple of issues solved that may have fixed this. Still having the issue? |
I'm having it still in GitHub Actions. I'm installing Playwright directly in the actions container:
You can check out code in my PR and check out actions results. Any tips on that one @osis @conwayconstar? |
I'm also noticing this issue breaking in CI where wallet.approve just doesn't work :/. It ends up just hanging on wallet for the new extension page. @osis any ideas? I can upload my Playwright trace if that helps ![]() |
Yea, the GitHub actions behaviour has been a bit tricky to track down. There are some known behavioural issues with playwright. Are you saying that it's waiting for the pop up context? |
Yeah that seems to be the problem, hangs on waiting for the pop up context. Are there currently any E2E tests in this Repo that run in GH actions? |
still cannot get it working on github actions, is someone working on this repo or is archived? |
Feel free to PR a fix if you know where the flow is breaking. Otherwise it's hard to debug without context/logs. The flow shown above isn't necessarily what approve was meant for so would love to understand the use case so we can expand the test suite to cover this. |
Hi @osis Error log: PR: Demo app repo: You can test it by:
|
Hi @osis I found out that CI works with this playwright.yml (it doesn't work if
|
I had the same issue: Unable to approve certain Metamask pop-ups. I created this lib, which creates a headless Browser Mock Wallet for testing: https://github.com/johanneskares/wallet-mock |
Any fixes here? |
I thin can be dynamic addresses , just use a fixed wallet address |
As far as I understood, it happens due to the headless mode on running on CI. As I found: I set the "headless: false" for dappwright.bootstrap calling and added "xvfb-run" for test running command.
My bootstrap call: I hope it'll help somebody |
Describe the bug
I am trying to run the tests in CI with github actions. It completes the tests up to the point where it needs to connect to meta mask.
Bellow is my code for the test.
The script i run in CI uses
xvfb-run
My workflow file runs this task
Logs
Expected behavior
Its supposed to pass the test for accepting the request.
Screenshots
I have added
System:
Additional context
I have attached my traces view them with this link https://trace.playwright.dev
trace.zip
The text was updated successfully, but these errors were encountered: