Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve locking sitatuation around -[ASDisplayNode clearContents] #1104

Closed
maicki opened this issue Sep 8, 2018 · 1 comment
Closed

Improve locking sitatuation around -[ASDisplayNode clearContents] #1104

maicki opened this issue Sep 8, 2018 · 1 comment

Comments

@maicki
Copy link
Contributor

maicki commented Sep 8, 2018

Currently -[ASDisplayNode clearContents] is accessing instance variables and therefore should be prefixed with _locked, but subclasses like -[ASCollectionNode clearContents] is accessing properties via selfor sometimes instance variables. We should improve the situation around clearContents and make it clear when we need to grab a lock or when the method is already called with the lock held.
This was referenced Sep 8, 2018
Merged
Merged
@maicki
Copy link
Contributor Author

maicki commented Sep 15, 2018

Closed via #1107

@maicki maicki closed this as completed Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maicki