Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASExperimentalDrawingGlobal causes performance regressions #1703

Open
rqueue opened this issue Oct 7, 2019 · 2 comments
Open

ASExperimentalDrawingGlobal causes performance regressions #1703

rqueue opened this issue Oct 7, 2019 · 2 comments

Comments

@rqueue
Copy link
Contributor

rqueue commented Oct 7, 2019

In testing the ASExperimentalDrawingGlobal feature, it was found to cause performance regressions with no noticeable memory improvements when released widely. However, we cannot rule out this feature entirely because it seems to be the only way to support wide gamut images. What should we do about this feature?

@bolsinga
Copy link
Contributor

bolsinga commented Oct 8, 2019

@Adlai-Holler This landed with #1469 @rqueue Would you be able to summarize what you found here? Thanks.

@Adlai-Holler
Copy link
Member

Earlier this year we saw OOMs improve. Re-running the experiment now with the same exact flag, we see performance regressions and neutral memory. #1696 should fix it – the current iteration does not support cancellation of actually forming the UIImage, which is pretty important and does get used in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants