Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASDisplayNode vertical hit point is incorrect inside ASCollectionNode when inverted set to true #1763

Closed
kelhutch17 opened this issue Jan 10, 2020 · 0 comments · Fixed by #1781

Comments

@kelhutch17
Copy link

I have an inverted ASCollectionNode (_collectionNode.inverted = YES;). My collection node items contain some ASDisplayNodes. The tap targets we have setup on these nodes have incorrect (possibly inverted) hit areas now. This issue is not present in 2.7.0, but it is present in 2.8.1 (I did not test 2.8 explicitly but I assume the issue was introduced there as 2.8.1 was a small release).

Example:
I overrode this method in my ASDisplayNode subclass

- (UIView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event {
  NSLog(@"point: x(%f), y(%f)", point.x, point.y);
  return [super hitTest:point withEvent:event];
}

When tapping an area of the node in 2.7.0, I see ~(x: 16, y: 13). In 2.8.1 I now see ~(x: 16, y: 83) when tapping the same approximate area of the node.


This might be related to: #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant