Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship Decision on ASExperimentalDrawingGlobal #1851

Open
bolsinga opened this issue May 27, 2020 · 4 comments
Open

Ship Decision on ASExperimentalDrawingGlobal #1851

bolsinga opened this issue May 27, 2020 · 4 comments

Comments

@bolsinga
Copy link
Contributor

bolsinga commented May 27, 2020 •
edited
Loading

ASExperimentalDrawingGlobal is in the code. Should it be on or off?

Landed with #1469
@bolsinga
Copy link
Contributor Author

@Adlai-Holler Do you know the status of this for other clients? Thanks.

@Adlai-Holler
Copy link
Member

Google is not currently shipping this, after seeing results we don't like. The monochrome buffer (aka auto context) was actually backported to UIGraphicsBeginImageContext at some point, I'm thinking iOS 13, so the benefit we were looking for isn't there anymore.

I don't work on that project anymore but I doubt they will proceed with it. I recommend removing it from the code unless Pinterest has contradictory results. cc @wiseoldduck who does still work on it.

@bolsinga
Copy link
Contributor Author

Thanks @Adlai-Holler

@bolsinga
Copy link
Contributor Author

Followed up with #1814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Adlai-Holler @bolsinga