Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculatedLayoutDidChange may be called needlessly. #422

Closed
Adlai-Holler opened this issue Jul 6, 2017 · 0 comments
Closed

calculatedLayoutDidChange may be called needlessly. #422

Adlai-Holler opened this issue Jul 6, 2017 · 0 comments

Comments

@Adlai-Holler
Copy link
Member

If you have a node that participates in a layout transition, but whose layout doesn't change, it'll still get calculatedLayoutDidChange because _pendingLayoutTransitionDidComplete calls it unconditionally:

screen shot 2017-07-05 at 6 35 13 pm

We should either:

  • Not call _pendingLayoutTransitionDidComplete if there was no pending layout transition.
  • Pass the nullable transition as an argument, and only call calculatedLayoutDidChange if it actually changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant