You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A few months ago, I was experiencing some (Swift) bridging crashes due to the ASNetworkImageNode calling ASImageDownloaderProtocol methods with a nil URL. At the time, I had put up a PR that solved the problem.
It seems that recent improvements to the ASNetworkImageNode have changed the way it calls the ASImageDownloaderProtocol, and I'm getting a new bridging crash on this line. I haven't tried reproducing the bug in a sample project yet, but [urls lastObject] can clearly be nil if urls is empty, whereas downloadImageWithURL expects a nonnull URL.
Because I haven't kept up with the latest improvements in the ASNetworkImageNode, I don't feel confident submitting a PR myself, maybe @garrettmoon could help here?
Tell me if you need anything else.
Cheers,
Flo
The text was updated successfully, but these errors were encountered:
Hi guys,
A few months ago, I was experiencing some (Swift) bridging crashes due to the
ASNetworkImageNode
callingASImageDownloaderProtocol
methods with anil
URL. At the time, I had put up a PR that solved the problem.It seems that recent improvements to the
ASNetworkImageNode
have changed the way it calls theASImageDownloaderProtocol
, and I'm getting a new bridging crash on this line. I haven't tried reproducing the bug in a sample project yet, but[urls lastObject]
can clearly benil
ifurls
is empty, whereasdownloadImageWithURL
expects anonnull
URL.Because I haven't kept up with the latest improvements in the
ASNetworkImageNode
, I don't feel confident submitting a PR myself, maybe @garrettmoon could help here?Tell me if you need anything else.
Cheers,
Flo
The text was updated successfully, but these errors were encountered: