Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASNetworkImageNode] Crash due to calls to ASImageDownloaderProtocol with nil URL #683

Closed
flovouin opened this issue Nov 22, 2017 · 1 comment
Assignees

Comments

@flovouin
Copy link
Contributor

Hi guys,

A few months ago, I was experiencing some (Swift) bridging crashes due to the ASNetworkImageNode calling ASImageDownloaderProtocol methods with a nil URL. At the time, I had put up a PR that solved the problem.

It seems that recent improvements to the ASNetworkImageNode have changed the way it calls the ASImageDownloaderProtocol, and I'm getting a new bridging crash on this line. I haven't tried reproducing the bug in a sample project yet, but [urls lastObject] can clearly be nil if urls is empty, whereas downloadImageWithURL expects a nonnull URL.

Because I haven't kept up with the latest improvements in the ASNetworkImageNode, I don't feel confident submitting a PR myself, maybe @garrettmoon could help here?

Tell me if you need anything else.

Cheers,
Flo

@garrettmoon garrettmoon self-assigned this Dec 5, 2017
@garrettmoon
Copy link
Member

@flovouin I think #699 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants