GIF not cached

[harri121]

I am using ASNetworkImageNode to display remote GIFs. The GIFs are not cached but downloaded everytime they are displayed. Not animated images are cached properly.
Am I missing something? Do I have to write a custom cache to cache GIFs?

[ghost]

I’m seeing a similar issue. Any workarounds @harri121?

[vldalx]

I've got the same issue.

Actually, animated images are cached, but ASNetworkImageNode ignores them and downloads every time.

The problem is here

Texture/Source/ASNetworkImageNode.mm

Lines 784 to 788 in 2e95f55

	if ([imageContainer asdk_image] == nil && _downloader != nil) {
	[self _downloadImageWithCompletion:^(id<ASImageContainerProtocol> imageContainer, NSError *error, id downloadIdentifier, id userInfo) {
	finished(imageContainer, error, downloadIdentifier, ASNetworkImageSourceDownload, userInfo);
	}];
	} else {

ASNetworkImageNode checks if imageContainer keeps an image, but doesn't check if the one keeps an animated image.

the if condition should be like this

[imageContainer asdk_image] == nil && [imageContainer asdk_animatedImageData] == nil && _downloader != nil

[vldalx]

@TextureGroup please, take a look at this issue. the one doesn't seem hard to fix

[SolorzanoJose]

@TextureGroup can you implement the fix provided above?

[harri121]

+1

[strangeliu]

+1

[citynight]

I have the same problem. How did you solve it?

[SolorzanoJose]

@LXZzzzzz there's no way to solve it, these guys need to accept the merge for the fix...

[ay8s]

Don't see a PR for this. Feel free to submit one. 👍