-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIF not cached #817
Comments
I’m seeing a similar issue. Any workarounds @harri121? |
I've got the same issue. Actually, animated images are cached, but The problem is here Texture/Source/ASNetworkImageNode.mm Lines 784 to 788 in 2e95f55
ASNetworkImageNode checks if imageContainer keeps an image, but doesn't check if the one keeps an animated image.
the [imageContainer asdk_image] == nil && [imageContainer asdk_animatedImageData] == nil && _downloader != nil |
@TextureGroup please, take a look at this issue. the one doesn't seem hard to fix |
@TextureGroup can you implement the fix provided above? |
+1 |
1 similar comment
+1 |
I have the same problem. How did you solve it? |
@LXZzzzzz there's no way to solve it, these guys need to accept the merge for the fix... |
Don't see a PR for this. Feel free to submit one. 👍 |
I am using ASNetworkImageNode to display remote GIFs. The GIFs are not cached but downloaded everytime they are displayed. Not animated images are cached properly.
Am I missing something? Do I have to write a custom cache to cache GIFs?
The text was updated successfully, but these errors were encountered: