Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use read_psd from S3_WRITE #51

Closed
achafetz opened this issue Jul 8, 2024 · 0 comments
Closed

Cannot use read_psd from S3_WRITE #51

achafetz opened this issue Jul 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@achafetz
Copy link
Contributor

achafetz commented Jul 8, 2024

By default, the bucket for reading in a file using read_psd is from the S3_READ bucket.

gophr/R/read_psd.R

Lines 84 to 86 in 1dfa65b

"pdap" = aws.s3::s3read_using(handle_psd_format,
bucket = Sys.getenv("S3_READ"),
object = file))

This could be a param, but ideally we want the user to be able to run the same code on their local machine or in Workbench. To do so, we need a sub function build into read_psd that checks if the PSD exists in S3_READ and if not, checks for it in S3_WRITE.

@achafetz achafetz added the enhancement New feature or request label Jul 8, 2024
@achafetz achafetz self-assigned this Jul 8, 2024
@achafetz achafetz mentioned this issue Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant