npm start script no longer creates dist folder

[thegarbz]

While working on the status bar I cloned a completely fresh copy of your repo. After running npm install and npm start big it resulted in an error that the svg files in the dist folder couldn't be found.

After a bit of digging it seems that a dist folder is no longer automatically created by the start script. I'm not sure when this error arose but the above instructions (listed in your CONTRIBUTING.md file) worked fine a few months ago.

Temporary workaround:
execute npm run-script build which does create a dist folder.
After this the npm start commands work just fine.

[UnchartedBull]

can't really change that. I improved the electron packaging (so now only dist is included), so the icon can't be accessed from src anymore. You only need to run npm run build once though, after that the dist folder should be available and npm run start:big should work normally. I'll add that to the CONTRIBUTING file.

[thegarbz]

Yes correct the build script only needed to be run once. Okay good to know it wasn't a bug :-)

[UnchartedBull]

Hi!

Didn't find an e-mail of yours, so hopefully this reaches you :)

Really great stuff you keep contributing to OctoDash, thanks! Just wanting to offer the contributed status to you. This would enable you to directly create branches and assign/close/label issues and more stuff.

No pressure though, I totally understand if you'd like to stay a contributor, no hurt feelings here :).

[thegarbz]

Hey, I didn't realise my email address was set to private. Fixed that, it's now shown on my profile.

Sure I'd be happy to have contributor status. But I'd limit my involvement to changing labels on issues. I don't want to touch branching on your project since I'm way too new to Github and I don't want to risk breaking something. :-)

[UnchartedBull]

You should've received an invitation mail from GitHub 👍

Feel free to create branches though, as long as you don't merge into master without approval everything should be fine. Plus the awesome thing about GitHub is that everything can be reverted :)

[thegarbz]

Thanks.

[Hussi503]

i was npm run build but still dist folder is not creating here is the package.json below for few not entire.

"scripts": {
"prestart": "npm install",
"build": "npm run prestart && gulp build && npm run clean && npm run lint:fix && ./node_modules/.bin/tsc",
"build:dev": "npm run prestart && gulp --dev ",
"build:azure": "npm run prestart && gulp --azure",
"build:release": "npm run prestart && gulp --optimizeCode",
"start": "gulp serve --dev",
"test": "npm run build",
"postinstall": "npm install -g typescript"