Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babystepping settings arent stored permanently #1293

Closed
ChristianH99 opened this issue Jan 9, 2021 · 4 comments · Fixed by #1621
Closed

Babystepping settings arent stored permanently #1293

ChristianH99 opened this issue Jan 9, 2021 · 4 comments · Fixed by #1621
Assignees
Labels
enhancement New feature or request

Comments

@ChristianH99
Copy link

The save button doesn't execute M500 command to store the offset. It is only stored until the printer is restarted, so the save button has no use.

Steps to reproduce the behavior:

  1. Start print
  2. Go to adjust
  3. Select babystepping
  4. Adjust settings
  5. Go back
  6. Click save

Expected behavior
The adjusted offset is stored permanently using the M500 command.

General Information:

  • Raspberry Pi 3 B +
  • OctoDash V2.1.2
@ChristianH99 ChristianH99 added the bug Something isn't working label Jan 9, 2021
@UnchartedBull
Copy link
Owner

That currently is by design. Maybe I understand the functionality wrong here, but AFAIK Marlin doesn't save babystepping during printer either, but you rather have to send M500, or am I wrong here?

@UnchartedBull UnchartedBull added discussion Issue needs to be discussed further and removed bug Something isn't working labels Jan 23, 2021
@ChristianH99
Copy link
Author

I‘m not sure how marlin deals with this and I have disabled all that functions on my printer to save memory, but as far as I remember you have to click save to store the value permanently as well.

@UnchartedBull
Copy link
Owner

Oh I didn't read your last step properly. I'll probably include a separate safe button in the Babystepping screen. Using the save button on the adjust screen could lead to some problems (since you need to press that to save the adjustments).

@UnchartedBull UnchartedBull added enhancement New feature or request and removed discussion Issue needs to be discussed further labels Jan 23, 2021
@ChristianH99
Copy link
Author

Yes that would be perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants