-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OctoLight #1358
Comments
Leaving this open for discussion. |
Only problem I see with this is that there's 10 other plugins for Octopi which also control LEDs and all do it in a different way :-/ |
Just like there is 10 other plugins for controlling printer power besides PSUControl. So what? |
Errr, there's not. There's only one plugin that functions as PSU control from the I/O. But that's not my point. My point was more that simple may not be an ideal target for a feature. A generic I/O plugin may be better to implement, or a more comprehensive plugin that supports a wider range of use cases than simply toggling the light off and on. e.g. Implementing the same functionality in Octoprint-RGB-Status means you cover the users of all PWM strips, WS281x strips, as well as GPIO users such as yourself. |
I meant all the plugins for wireless sockets etc. |
Yeah it was just a suggestion to the maintainer to implement something that could work for a larger audience. I'd like the idea too. That said if RGB-Status doesn't work on the latest Octoprint the topic may be moot. Last push was 8 months ago. Maybe it's not being maintained :( I'm still a few versions behind on Octoprint. |
Have you tried achieving the same control with the Enclosure plugin? This on is already integrated and adding the functionality to add toggling a GPIO pin via the custom actions would be really easy and could be done with the next update. Enclosure plugin is also still running on 2.x unfortunately, but the author said the python 3 version is in the making. |
I followed Timos advice with the Action Commands / Enclosure plugin route, while it works fine, it took a while to figure out the philosophy behind it, since there are no step by step tutorials for noobs and outsiders. The only thing philosophically I have against this is, there are more things involved then needed for a simple problem. OctoDash->GCODE->OctoPrint->ActionCommands, for the sake of trouble shooting a single step would be 'cleaner' but clearly more work and maintenance. While on the topic, the only vexing thing about it is - that once in print/operation mode, the action pallet can no longer be opened - hence lights not directly controlled - nearly defeats installing them on a button in the first place. |
If you have it working with the Enclosure Plugin I can add support for triggering outputs there directly via Custom Actions so you won't need the ActionsCommands part anymore. Custom Actions probably will come in the version after the next release. |
I have it working with the Enclosure Plugin the whole time, but I take it only as a workaround, since it is quite unpractical. I didn't find a way to make it toggle, so there must be two actions for ON and OFF. Thus in OctoDash must be also two actions used up. Furthermore this way it doesn't share the current state of the GPIO. If I toggle Octolight off, then turn on using Enclosure Plugin, then I have to click 2x on the Octolight icon to turn off again. It is really not a good solution. |
And yes, there should be option to access some Actions during print. |
Me personally I dont like toggle options, since they do not have a defined state, specially when activated via push-button logic. I prefer to have to have separate on/off commands, or a read-back / pull function to get the current state. In my case I switch via web interface when accessing the enclosure camera, via PIR sensor when I walk up to the machine, or via button on the console / touch screen. Hence being able to send clear On/Off is vital in my case. I solved most of this by having a dedicated arduino on USB/Serial that receives commands, so I can give it more logic and control. The same controller feeds temp/humidty info back to octopi/dash, controls the fans in the enclosure etc.. All the octoprint does is trigger dedicated python scripts that send the commands to serial. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'd like a support for this plugin: https://github.com/gigibu5/OctoLight in the Custom Actions of the OctoDash. The same way the PSUControl is supported.
Thanks
The text was updated successfully, but these errors were encountered: