Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Cant Retrieve Folder" notification if "Back" button is pressed, or if folder data is successfully retrieved #1520

Closed
scottmudge opened this issue Mar 4, 2021 · 1 comment
Labels
enhancement New feature or request
Projects

Comments

@scottmudge
Copy link

scottmudge commented Mar 4, 2021

Is your feature request related to a problem? Please describe.
Often OctoDash cannot retrieve folder information from OctoPrint. Usually this happens around the time a file is sent via ethernet to OctoPrint, so perhaps OctoPrint is just busy parsing or reading the file, so it doesn't return folder data.

In any case, if I hit "back" and try again in OctoDash, it generally can view the files after the 2nd or 3rd retry.

However, a few seconds after hitting the back button and successfully retrieving the folder data, OctoDash will still show a "Failed to retrieve folder" error notification from the prior attempts that timed out (I guess it's still trying to retrieve the folder data on a separate thread, even though I backed out in the UI). This error still shows up even if I've already backed out of them and successfully retried and started printing a file.

Describe the solution you'd like
Can this "Failed to Retrieve Folder" error be disabled if the back button is pressed, or if OctoDash successfully retrieves folder data in-between when the first failed attempt is made, and when the timeout occurs?

@scottmudge scottmudge added the enhancement New feature or request label Mar 4, 2021
@scottmudge scottmudge changed the title Disable "Cant Retrieve Folder" notification if "Back" button is pressed Disable "Cant Retrieve Folder" notification if "Back" button is pressed, or if folder data is successfully retrieved Mar 4, 2021
@UnchartedBull UnchartedBull added this to To do in v3 Release via automation Mar 5, 2021
@UnchartedBull
Copy link
Owner

Should hopefully be fixed with #1438. If the error comes up again reopen this issue please.

v3 Release automation moved this from To do to Done Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v3 Release
  
Done
Development

No branches or pull requests

2 participants