Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File sort by date and thumbnails #1583

Closed
mpalm0508 opened this issue Mar 20, 2021 · 1 comment · Fixed by #1588
Closed

File sort by date and thumbnails #1583

mpalm0508 opened this issue Mar 20, 2021 · 1 comment · Fixed by #1588
Assignees
Labels
bug Something isn't working

Comments

@mpalm0508
Copy link

Describe the bug
I am running a local build from merge cb70bc4. When files are sorted by date month is reversed. For instance a file from February 20th shows in the list before a file from March 10 when being sorted by descending. If you sort by Ascending it is the exact reverse. I can get correct sort by modifying line 59 in files.octoprint.services.ts to the following. However I do not know what all affect that has.

date: this.conversionService.convertDateToString(new Date(fileOrFolder.date * 1)),

The second issue is while printing files with thumbnails the thumbnail is of the next file in the list. So If I print file "A" the thumbnail for file "B" is shown.

I know there were a lot of changes to get websockets running. I just wanted to bring up a couple bugs I have found.

Mike

@mpalm0508 mpalm0508 added the bug Something isn't working label Mar 20, 2021
@UnchartedBull
Copy link
Owner

Thanks for this! Your fix does seem to work and I didn't saw anything that got broken with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants