Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted file still shown in File List #164

Closed
UnchartedBull opened this issue Sep 30, 2019 · 6 comments
Closed

Deleted file still shown in File List #164

UnchartedBull opened this issue Sep 30, 2019 · 6 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@UnchartedBull
Copy link
Owner

Deleted Files are still being returned by the API and therefore shown in the UI. Confirmed with Postman, as deleted file is included in file list. File is gone in Octoprint UI File List immediately.

@UnchartedBull UnchartedBull added the bug Something isn't working label Sep 30, 2019
@UnchartedBull UnchartedBull self-assigned this Sep 30, 2019
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Sep 30, 2019
@UnchartedBull UnchartedBull moved this from To do to Blocked in v2 Release Oct 8, 2019
@hessius
Copy link
Contributor

hessius commented Oct 18, 2019

I've noticed the same issue with the file manager plugin (see screenshot).

Shouldn't it be possible to match the path to exclude anything containing "trashe~"

image

@UnchartedBull
Copy link
Owner Author

Oh that's actually quite intereseting. I never bothered to look at the full path for a deleted file and was just wondering why they don't show up. If they always include the trashe~ prefix it will be very easy to exclude them. Thanks for the tip!

@hessius
Copy link
Contributor

hessius commented Oct 19, 2019

It also looks like the filenames all end with ~1 (potentially ~n) which should also be an easy regex filter

@UnchartedBull UnchartedBull moved this from Blocked to In progress in v2 Release Jan 22, 2020
@UnchartedBull
Copy link
Owner Author

UnchartedBull commented Feb 6, 2020

Coming back to this. I just tried it on my system and I can't reproduce this issue, at least not in your way. If i delete a file via the UI it will still be shown in OctoDash, that's due to the fact that the API doesn't get updated though. As you can see in the screenshot the path doesn't change to trashe*. This is related to #400 as they both narrow down to the API not updating, even though the OctoPrint website is updating. I will create an issue in the OctoPrint repository tomorrow to hopefully get this fixed soonish. Once the API is updating correctly the files should be removed from OctoDash as well.

Screenshot of a file that was deleted:
Screenshot 2020-02-07 at 00 24 53

Also I can't seem to find the trashe folder on my system. Is this maybe something that gets added by the plugin you mentioned? At least on my system there is no trace of a trashe folder:
Screenshot 2020-02-07 at 00 28 19

@UnchartedBull
Copy link
Owner Author

I just found this regarding the trash folder: OctoPrint/OctoPrint#1406. Are the files you are mentioning on the SD Card by any chance?

@UnchartedBull
Copy link
Owner Author

Closing this in favour of #400 and OctoPrint/OctoPrint#3446

v2 Release automation moved this from In progress to Done Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v2 Release
  
Done
Development

No branches or pull requests

2 participants