Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve offline response & Connect to Printer #202

Closed
hessius opened this issue Oct 13, 2019 · 4 comments
Closed

Improve offline response & Connect to Printer #202

hessius opened this issue Oct 13, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@hessius
Copy link
Contributor

hessius commented Oct 13, 2019

As mentioned in #20 and #201 I would love to have an improved error handling for offline printers.
As I turn off my printer automatically after finishing a print it's not uncommon that the printer is offline. Even after turning on the printer it's not connected (and I haven't been able to get it to automatically connect either).

So I would like an error message that isn't as obtrusive as the current one, but maybe displays as a red bottom bar (instead of a modal that needs to be closed). Ideally this message would have a proposed action like "connect"

@UnchartedBull UnchartedBull self-assigned this Oct 13, 2019
@UnchartedBull UnchartedBull added the enhancement New feature or request label Oct 13, 2019
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Oct 13, 2019
@UnchartedBull
Copy link
Owner

Yes that is one of the points that need to be addressed some time soon. I'll have a look at how this could be done. One thing to keep in mind is the memory leak prone console. As Chrome keeps all errors in the console forever I think.

@hessius
Copy link
Contributor Author

hessius commented Oct 14, 2019

I did not know that!
And running
console.clear()
Doesn’t clear errors either?

(Documentation https://developer.mozilla.org/en-US/docs/Web/API/Console/clear)

@UnchartedBull
Copy link
Owner

I have to do some digging around that, but it seems like this function can be used in Chrome. Big Question is, whether all the pointers to the variables are cleared as well, so they can be garbage collected. I'll do some research and think of something that could be integrated ...

@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release Oct 14, 2019
@UnchartedBull
Copy link
Owner

It is kind off working with some hickups here and there. I now want to gradually introduce a future stop for v2, because otherwise it will never get finished. #214 already addresses the issue and will be worked on, once v2 is finished.

v2 Release automation moved this from In progress to Done Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

No branches or pull requests

2 participants