Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation Dialog for some custom commands/actions? #225

Closed
spiff72 opened this issue Oct 17, 2019 · 4 comments
Closed

Confirmation Dialog for some custom commands/actions? #225

spiff72 opened this issue Oct 17, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@spiff72
Copy link

spiff72 commented Oct 17, 2019

Is your feature request related to a problem? Please describe.
Somewhat...
Some of the commands in the custom commands/actions are "dangerous" - e.g. Shutdown, Kill).

Describe the solution you'd like
Could there be a simple confirmation dialog that could be implemented in cases where a command could be harmful to the system? (Maybe just add a flag to the config file that adds the confirmation dialog for certain commands?)

@spiff72 spiff72 added the enhancement New feature or request label Oct 17, 2019
@UnchartedBull
Copy link
Owner

Great idea. I'll definitely make sure to include that.

I'm currently trying to do some kind of a Feature Stop for OctoDash v2 so it finally gets released. Therefore I'll move this issue to after the release of OctoDash. Sorry for the wait. It will be one of the first issues taken care off after the v2 release :)

@UnchartedBull UnchartedBull self-assigned this Oct 17, 2019
@UnchartedBull UnchartedBull added this to To do in Future via automation Oct 17, 2019
@spiff72
Copy link
Author

spiff72 commented Oct 17, 2019

No problem. Your responsiveness on this program is exceptional!

@UnchartedBull
Copy link
Owner

Thank you :)

@UnchartedBull
Copy link
Owner

Was introduced in 1.4.0, can be adjusted in the settings

Future automation moved this from To do to Done Mar 2, 2020
@UnchartedBull UnchartedBull removed this from Done in Future Apr 14, 2020
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Apr 14, 2020
@UnchartedBull UnchartedBull moved this from To do to Done in v2 Release Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

No branches or pull requests

2 participants