Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OctoDash stops print if connected during warmup. #446

Closed
MatthewCroughan opened this issue Feb 21, 2020 · 7 comments
Closed

OctoDash stops print if connected during warmup. #446

MatthewCroughan opened this issue Feb 21, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@MatthewCroughan
Copy link

If OctoDash is left unconnected and a print is taking place, it will stop the print in progress if a user connects.

What's interesting about this is that shows the layers in progress (Layer 0 of 117) for example.

I am unsure if this only happens if a print is heating up ready for print, but is not currently not really in progress (laying filament down). I can test this scenario later though.

@MatthewCroughan MatthewCroughan added the bug Something isn't working label Feb 21, 2020
@UnchartedBull
Copy link
Owner

Do you mean it stops the print via OctoPrint? Does this happen on Version 1.4.0? There were some issue with the connection, which were fixed in 1.4.0.

@MatthewCroughan
Copy link
Author

I'll check again with 1.4.0 tomorrow.

@MatthewCroughan
Copy link
Author

@UnchartedBull Apologies for taking so long to get back to you on this. Indeed this still occurs in 1.4.0. Also, it occurs if a print is running.

For example. Let's say I'm running this print:

image

If I tap the display, the print will stop. This has happened once already when someone was curious about my display.

I started the print remotely. It does this because when you ask the Octoprint api to connect, it indeed does connect. A reconnection stops all running jobs. I would say this is the fault of the Octoprint API. This would not be acceptable for the Espurna relay API for example. If you sent a value of 1 to espurna-name/relay/set/0 this does not turn the relay off and then on again, but that is what is happening in the case of Octoprint.

@UnchartedBull
Copy link
Owner

But this is what the API documents, so it is a fault of OctoDash. The thing is, that with 1.4.0 OctoDash first checks whether a connection is already established and only sends the connect command if there is no connection. Other users reported that this is working and OctoDash isn't issuing a reconnection command if OctoPrint is connected ...

Could you please post the reply of /api/connection just before you tap the screen and OctoDash triggers the reconnection?

@MatthewCroughan
Copy link
Author

@UnchartedBull I see. Thanks much for explaining those details.

So, I do have the PSUControl option enabled in the OctoDash config. Does that also check for this state before issuing a power on? I'll check these states when I'm in the workshop again in 8~ hours.

@UnchartedBull
Copy link
Owner

https://github.com/UnchartedBull/OctoDash/blob/master/src/app/standby/standby.component.ts#L36 that is the relevant code bit. PSUControl always get's called to turn the printer on, no matter the current connection state. But as you already said this isn't an issue, since PSUControl does not turn the printer off and on again, if it is already on. I check if PSUControl triggers a connect command as well.

@UnchartedBull
Copy link
Owner

Will be tracked in #368. My fix doesn't seem to work reliably. Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants