Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New way of resetting running values #610

Closed
RC-Thoughts opened this issue May 2, 2020 · 4 comments · Fixed by #653
Closed

New way of resetting running values #610

RC-Thoughts opened this issue May 2, 2020 · 4 comments · Fixed by #653
Labels
enhancement New feature or request
Projects

Comments

@RC-Thoughts
Copy link

Made a small change in behavior of adjusting running values from main screen, useful when playing with tuning etc.

Video here: https://youtu.be/-klEuE8iGfg

@RC-Thoughts RC-Thoughts added the enhancement New feature or request label May 2, 2020
@RC-Thoughts
Copy link
Author

Examples below of the quick'n'dirty hack.

printer-status.components.ts

private changeTemperatureHotend(value: number): void { this.hotendTarget += value; if (this.hotendTarget < -999) { this.hotendTarget = this.configService.getDefaultHotendTemperature(); } if (this.hotendTarget < 0) { this.hotendTarget = 0; } if (this.hotendTarget > 999) { this.hotendTarget = 999; } }

printer-status.component.html:

<div class="quick-control__controller-value" colspan="2" *ngIf="view === QuickControlView.HOTEND" (click)="quickControlChangeValue(-1000)" matRipple [matRippleUnbounded]="false"> {{ this.hotendTarget }} <span class="quick-control__controller-value-unit">°C</span> </div>

You get the point :)

@UnchartedBull
Copy link
Owner

UnchartedBull commented May 2, 2020

That's a really neat idea :) Feel free to open a PR for that, is there any need to set the temp to -1000 though? I think 0 should be fine there, shouldn't it?

Nevermind, just saw the need for -1000.

@LanderN
Copy link

LanderN commented May 4, 2020

@RC-Thoughts sorry for the off-topic question, but what LCD are you using? It looks like it has very high FPS and responsiveness! Mine is a crappy cheap chinese one, which gets like 5fps, so I'm looking for a good replacement :)

@RC-Thoughts
Copy link
Author

It's Raspi 4 with Hyperpixel 4.0, really happy with it. Only downside is that no GPIO's are left over.

@UnchartedBull UnchartedBull added this to To do in v2 Release via automation May 15, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release May 18, 2020
v2 Release automation moved this from In progress to Done May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants