Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll to file name #627

Open
sa-egor opened this issue May 7, 2020 · 8 comments
Open

Add scroll to file name #627

sa-egor opened this issue May 7, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sa-egor
Copy link

sa-egor commented May 7, 2020

Hello!

Please add scrolling text (<marquee> or other) for div job-info__filename.
If filename long, not all text is displayed.
For example:

File name: CFFFP_Orange Pi PC and 3.5_ TFT display on 20x20mm profile lock.gcode

Lines for edit:

<span class="job-info__filename">{{ job.filename }}</span> <br />

<span class="job-info__filename">{{ job.filename }}</span> <br />

Thanks!

@UnchartedBull UnchartedBull added the discussion Issue needs to be discussed further label May 11, 2020
@UnchartedBull
Copy link
Owner

I think marquee isn't an official HTML tag and also looks a bit laggy. I'll have a look at this and see what I come up with. Definitely should be configurable, as I for example don't want my text to scroll.

@noxhirsch
Copy link
Contributor

I wouldn't want my names to scroll either. I'd rather prefer a smaller font or/and two lines. In my opinion the filament grams below the name has more use on the file selection (if you start a print directly, you already can find that info in the slicer), so that space could be used for a second line of the filename.

@ruralaccent
Copy link

ruralaccent commented May 22, 2020

I use long file names as part of my workflow and file management. I definitely agree that it needs to either scroll or cross two lines (or have options for this). Thank you! :)

@UnchartedBull
Copy link
Owner

I will work on this after the v2 release, so it might need a little more time.

@UnchartedBull UnchartedBull added enhancement New feature or request and removed discussion Issue needs to be discussed further labels May 22, 2020
@UnchartedBull UnchartedBull added this to To do in Future via automation May 22, 2020
@UnchartedBull UnchartedBull self-assigned this May 22, 2020
@noxhirsch
Copy link
Contributor

screenshot
Just a little sneak peek on the custom style I'm working on at the moment. This is of course not the printing screen, but it will be similar. One of my main goals is also to see as much as possible from the filename everywhere.

@noxhirsch
Copy link
Contributor

Update:

In the filelist filament and file size are now hidden (I think it is enough to find them in the file view), so more of the filename is visible (also the scrollbar is smaller):
screenshot_filelist

Full screen file view with big thumbnail (square thumbnails will be more narrow, of course):
screenshot_file

Many changes on the file loaded screen (also enough space for square thumbnails):
screenshot_file_loaded

The same changes on the printing screen:
screenshot

As soon as two HTML changes are implemented, everything is just CSS which can be used with the custom CSS file available in the next version of OctoDash.

@sa-egor
Copy link
Author

sa-egor commented May 23, 2020

Looks cool!

@UnchartedBull
Copy link
Owner

I merged one of the HTML changes, the other one will be merged soonish. Once you're done with your design feel free to create a PR. I'm thinking for now as a temporary solution:

There will be a directory at root level of this repo called themes, inside of which there will be folders with some nifty names for the different themes. Each theme folder should contain a couple of screenshots and the custom-css file for people to download. I think this will work great as an intermediate Theme Store.

themes
| -- nifty-name-1
| -- -- screenshots
| -- -- custom-styles.css
| -- nifty-name-2
...

@UnchartedBull UnchartedBull removed this from To do in Future Aug 19, 2020
@UnchartedBull UnchartedBull added this to To do in v3 Release via automation Aug 19, 2020
@UnchartedBull UnchartedBull removed this from To do in v3 Release Mar 18, 2021
@UnchartedBull UnchartedBull added this to To do in v4 Release via automation Mar 18, 2021
@UnchartedBull UnchartedBull removed this from To do in v4 Release May 3, 2021
@UnchartedBull UnchartedBull added this to the v3.2.0 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants