Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the close button overlay in the internet browser stay while navigating #713

Closed
graphiste opened this issue Jun 5, 2020 · 3 comments · Fixed by #753
Closed

Can the close button overlay in the internet browser stay while navigating #713

graphiste opened this issue Jun 5, 2020 · 3 comments · Fixed by #753
Labels
bug Something isn't working
Projects

Comments

@graphiste
Copy link

graphiste commented Jun 5, 2020

Hi, I use the internet page custom action to open Octprint on the enclosure plugin tab. It works great while navigating between the main Octoprint tabs.
If I click thugh on a link that is not a tab, the new page loads, but the close button desapears and I can not return to octodash screen.
Is it possible to aways have the close button overlay while navigating internet in kiosk mode?

@graphiste graphiste added the enhancement New feature or request label Jun 5, 2020
@UnchartedBull
Copy link
Owner

The close button should always stay, so this is a bug, will try to fix it for the next release.

@UnchartedBull UnchartedBull added bug Something isn't working and removed enhancement New feature or request labels Jun 6, 2020
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Jun 22, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release Jun 22, 2020
@UnchartedBull
Copy link
Owner

The linked PR will fix that issue. The problem is, that there is no way to display a website, if the link wants to open a new window. With the new implementation it will just ignore that link. While this means, that the close button will always be visible, it also means that you probably can't open the website that caused the issue anymore.

Can you maybe update the website to use targer="__self" instead of blank or similar?

@graphiste
Copy link
Author

Thank you very much for solving this issue.

v2 Release automation moved this from In progress to Done Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v2 Release
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants