Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary downloads #5

Open
gkluoe opened this issue May 14, 2019 · 0 comments
Open

Unnecessary downloads #5

gkluoe opened this issue May 14, 2019 · 0 comments

Comments

@gkluoe
Copy link
Contributor

gkluoe commented May 14, 2019

The processor is technically idempotent, insofar as it won't recreate a package if the output package already exists; however, before it determines whether the output package exists, it will download the ISO or DMG if it doesn't exist.

What should happen:

if package_exists:
    continue
elif download_exists:
    make_package
    continue
else:
    download
    make_package
    continue

Because of the way the helper script has grown organically, making it work like this will take a bit of refactoring which, currently, I'm leaving for another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant