Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrozenShock allows shock velocities below the speed of sound #4

Open
corykinney opened this issue Mar 13, 2023 · 1 comment
Open

FrozenShock allows shock velocities below the speed of sound #4

corykinney opened this issue Mar 13, 2023 · 1 comment

Comments

@corykinney
Copy link
Collaborator

Expected behavior:
FrozenShock should raise an exception for a u1 corresponding to a Mach number below 1.

@corykinney corykinney added the bug Something isn't working label Mar 13, 2023
@corykinney corykinney self-assigned this Mar 13, 2023
@corykinney corykinney added the enhancement New feature or request label Apr 25, 2023
@corykinney corykinney removed the bug Something isn't working label Jun 18, 2024
@corykinney
Copy link
Collaborator Author

Although FrozenShock generally crashes for a subsonic u1, an explicity check will prevent any chance of successfully arriving at an incorrect solution. Additionally, a more helpful error message is needed instead of a confusing linear algebra error that doesn't clearly indicate the actual issue.

@corykinney corykinney removed the enhancement New feature or request label Jun 18, 2024
@corykinney corykinney removed their assignment Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant