Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lobby must be removed automatically if there are no players in the lobby #31

Open
ALegostaeva opened this issue Oct 3, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@ALegostaeva
Copy link
Contributor

No description provided.

@Yankovsky Yankovsky added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2020
@Yankovsky
Copy link
Contributor

Yankovsky commented Oct 3, 2020

Also it should be removed if game hasn't started or if nothing happened in some period of time.

@lucasturci
Copy link
Contributor

Hello, I think I can implement this! But I don't know if it is possible to detect when a user leaves the lobby, since you don't have the websocket yet. Once you have the websocket, it is possible. What I can do now is delete the lobby after a timeout.

@Yankovsky
Copy link
Contributor

@lucasturci cool, we can use some help! I'll write some thoughts on the subject shortly.

@Yankovsky
Copy link
Contributor

Yankovsky commented Oct 3, 2020

@lucasturci I've assigned this task to you.

@lucasturci
Copy link
Contributor

Thankss

@Yankovsky
Copy link
Contributor

Yankovsky commented Oct 3, 2020

@lucasturci If the lobby is unchanged for 15 minutes, it should be deleted. Lobby is considered changed when list of lobby players change.
If you can add a test for timeout functionality it would be great! Test runner is already set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants