Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winloop is not work in uvicorn multiprocessing #11

Closed
yangy996 opened this issue Dec 15, 2023 · 7 comments
Closed

Winloop is not work in uvicorn multiprocessing #11

yangy996 opened this issue Dec 15, 2023 · 7 comments
Labels
bug Something isn't working question Further information is requested

Comments

@yangy996
Copy link

In uvicorn, I have added a new file “winloop.py”.
image
uvicorn/config.py:
image

Next:
from uvicorn import run
run("app_compat:create_app_fastapi", host="0.0.0.0",
workers=int(args["workers"]),
port=int(port),
loop="winloop",
factory=True)

Result:
image
Pid is 23052 and 4604.

Just,It is only running on PID 4604.

@Vizonex
Copy link
Owner

Vizonex commented Dec 15, 2023

@yangy996 There is still some work to be done around multiprocessing including aiomultiprocessing . Even I am having trouble understanding why it fails to work. We had an update recently so if you are on it, try using it and then see if you're still having the same issue. I am working on writing a unittest soon for multiprocessing problems in general. Try using version 0.1.0 to help you figure out if these problems still exists.

@Vizonex Vizonex added the bug Something isn't working label Dec 15, 2023
@yangy996
Copy link
Author

@yangy996 There is still some work to be done around multiprocessing including aiomultiprocessing . Even I am having trouble understanding why it fails to work. We had an update recently so if you are on it, try using it and then see if you're still having the same issue. I am working on writing a unittest soon for multiprocessing problems in general. Try using version 0.1.0 to help you figure out if these problems still exists.

The current version is 0.1.0.

@Vizonex
Copy link
Owner

Vizonex commented Dec 16, 2023

I am currently dealing with the blue-screen of death at the moment on my pc so your going to have to wait until I can fix it. I apologize for the inconvenience at the moment.
797DACF6-26DD-44B6-B7F5-7C81DB4D7686

When I get this problem solved I plan to first test aiomultiproccess and then go in by debugging everything step by step at a time until it finally works correctly.

@Vizonex
Copy link
Owner

Vizonex commented Feb 1, 2024

@yangy996 aiomultiproccessing and multiproccessing works fine now since our update so I guess my friend fixed it #14 And I just uploaded test suite on top of that. I would like your conformation first though before I decide to close this issue.

@Vizonex Vizonex added the question Further information is requested label Feb 1, 2024
@yangy996
Copy link
Author

yangy996 commented Feb 2, 2024

The current version is 0.1.1
It is not work.
S2FCC32728 CJ_UNX}VYBUC

@Vizonex
Copy link
Owner

Vizonex commented Feb 7, 2024

I was able to get it to spawn in 2 pids using a test via the aiomultiprocess library I will try to extend this into uvicorn very soon.

@Vizonex
Copy link
Owner

Vizonex commented Aug 30, 2024

I'm closing this issue because we solved this one a long time ago.

@Vizonex Vizonex closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants