Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional API methods for the tabs component #119

Open
VizuaaLOG opened this issue Nov 26, 2020 · 0 comments
Open

Additional API methods for the tabs component #119

VizuaaLOG opened this issue Nov 26, 2020 · 0 comments
Assignees
Milestone

Comments

@VizuaaLOG
Copy link
Owner

VizuaaLOG commented Nov 26, 2020

Over the next few versions I think it would great to expand the API methods available, allowing certain settings to be changed at run time, rather than needing to recreate the component. The below are ideas for the notification, any other ideas please just comment!

  • activeTab(): number - Returns the current index of the active tab
  • hoverable(new_state: boolean) - Sets if the tabs change on hover. Returns the current value if no parameter is provided.
  • trigger(event_name: string) - This will trigger the provided event on the notification instance. Note: This wouldn't be restricted to documented events, so could be used for handling custom events

New events

  • changed - Called when the active tab has changed. Sends the old and new index as parameters

New config

  • wrapperClassName - Defaults to tabs-wrapper, sets the wrapping div that this instance should use

The majority of the changes here will also apply to the PanelTabs component that is currently in master. #102

@VizuaaLOG VizuaaLOG self-assigned this Nov 26, 2020
@VizuaaLOG VizuaaLOG added this to the 0.13 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant