Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus static targets mode support #11

Closed
Vonng opened this issue Feb 18, 2021 · 1 comment
Closed

Prometheus static targets mode support #11

Vonng opened this issue Feb 18, 2021 · 1 comment
Assignees
Labels
ENHANCEMENT New feature or request
Milestone

Comments

@Vonng
Copy link
Owner

Vonng commented Feb 18, 2021

Scenario

Currently, postgres instance identity is managed by Consul Service Registration.
Which is implemented as local consul service configuration file in /etc/consul.d/svc-***.json
It is a distributed approach that allows instances themselves to 'report' their identity.
It do have some potential security issues such as wrong identity because of malicious or accidentally configured.

Some may prefer a centralized approach. E.g manage all identity in the meta-node.
Since we already have those information in inventory

Proposal

Take prometheus for example.
We can provide an alternative option to use static target identity file rather than service discovery.
Which may reduce the hazard of operating and reloading consul.

We can generate prometheus configuration with inventory and label all instance properly.
It also makes it much easier to integrate with other provisioning systems.

@Vonng Vonng added the ENHANCEMENT New feature or request label Feb 18, 2021
@Vonng Vonng added this to the v0.6 milestone Feb 18, 2021
@Vonng Vonng self-assigned this Feb 18, 2021
@Vonng Vonng changed the title Centralized Identity Management Prometheus static targets mode support Feb 18, 2021
@Vonng
Copy link
Owner Author

Vonng commented Feb 19, 2021

Resolved by 162bb69 and ea5877e

@Vonng Vonng closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCEMENT New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant