Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeguard for purge functionality #9

Closed
Vonng opened this issue Feb 18, 2021 · 1 comment
Closed

Safeguard for purge functionality #9

Vonng opened this issue Feb 18, 2021 · 1 comment
Assignees
Labels
ENHANCEMENT New feature or request
Milestone

Comments

@Vonng
Copy link
Owner

Vonng commented Feb 18, 2021

Scenario

It is very dangerous to set dcs_exists_action = clean and pg_exists_action = clean, Which are safeguard variables to avoid accidentally removing any running databases or dcs instances.

It is always better to achieve that by an explicit playbook execution pgsql-rm.yml rather than change a variable.
In some case you just want to erase that possibility.

Proposal

Add two safeguard variables pg_disable_purge and dcs_disable_purge. If set to true, corresponding variable pg_exists_action and dcs_exists_action will be forced to abort to avoid purge.

@Vonng Vonng added the ENHANCEMENT New feature or request label Feb 18, 2021
@Vonng Vonng added this to the v0.6 milestone Feb 18, 2021
@Vonng Vonng self-assigned this Feb 18, 2021
@Vonng
Copy link
Owner Author

Vonng commented Feb 19, 2021

Resolved by :
2f3ce85
b09c7c2

@Vonng Vonng closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCEMENT New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant