Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup/enhancement suggestions #20

Open
kavanase opened this issue Aug 10, 2024 · 2 comments
Open

Code cleanup/enhancement suggestions #20

kavanase opened this issue Aug 10, 2024 · 2 comments

Comments

@kavanase
Copy link
Contributor

Some small suggestions:

  • The anharmonic example notebook is 32 Mb which is too large to display on GitHub, whereas the next largest notebook is the updated workflow one which is only 2 Mb and has as many plots in it. I'm not sure what the issue is here, but I think just re-running this notebook and saving might fix this (I think we added some plotting updates before to fix this? Otherwise using whatever options are used in the CarrierCapture_workflow notebook to reduce these unnecessarily large plot sizes)
image
  • It would be good to give an example notebook for generating the input structures for the carrier capture calculation. Currently this is only shown using the gen_cc_struct.py script here, which also assumes that the two structures are correctly symmetry-matched. I think I sent you some example notebooks for this before @xw-w (symmetry-matching the structures and generating the selected path structures)? Would you mind uploading one to the example/notebook folder? I've attached an example of doing this for NEB calculations in case needed (same steps just changing the selection of Q coordinates)
    Example_NEB_Path_Generation.ipynb.zip

  • Less urgent but good housekeeping; currently the readme points to some of the old (deprecated) notebooks as example usages. Would be good to update this to point to the new recommended workflow (i.e. the CarrierCapture_workflow notebook)

@kavanase
Copy link
Contributor Author

I tried tackling the first of these myself but I don't have julia installed on my laptop currently so it's a pain. Should hopefully only take a minute or two to re-run that notebook if you already have julia up and running!

@kavanase
Copy link
Contributor Author

Slightly updated path generation notebook here!
Example_CC_Path_Generation.ipynb.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant